| From 5c7399947d480d06215118d713e3937a56ad8b8f Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 2 Jun 2022 08:24:30 +0400 |
| Subject: soc: qcom: ocmem: Fix refcount leak in of_get_ocmem |
| |
| From: Miaoqian Lin <linmq006@gmail.com> |
| |
| [ Upstream commit 92a563fcf14b3093226fb36f12e9b5cf630c5a5d ] |
| |
| of_parse_phandle() returns a node pointer with refcount |
| incremented, we should use of_node_put() on it when not need anymore. |
| Add missing of_node_put() to avoid refcount leak. |
| of_node_put() will check NULL pointer. |
| |
| Fixes: 88c1e9404f1d ("soc: qcom: add OCMEM driver") |
| Signed-off-by: Miaoqian Lin <linmq006@gmail.com> |
| Reviewed-by: Brian Masney <masneyb@onstation.org> |
| Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> |
| Link: https://lore.kernel.org/r/20220602042430.1114-1-linmq006@gmail.com |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/soc/qcom/ocmem.c | 3 +++ |
| 1 file changed, 3 insertions(+) |
| |
| diff --git a/drivers/soc/qcom/ocmem.c b/drivers/soc/qcom/ocmem.c |
| index 85f82e195ef8..1dfdd0b9ba24 100644 |
| --- a/drivers/soc/qcom/ocmem.c |
| +++ b/drivers/soc/qcom/ocmem.c |
| @@ -194,14 +194,17 @@ struct ocmem *of_get_ocmem(struct device *dev) |
| devnode = of_parse_phandle(dev->of_node, "sram", 0); |
| if (!devnode || !devnode->parent) { |
| dev_err(dev, "Cannot look up sram phandle\n"); |
| + of_node_put(devnode); |
| return ERR_PTR(-ENODEV); |
| } |
| |
| pdev = of_find_device_by_node(devnode->parent); |
| if (!pdev) { |
| dev_err(dev, "Cannot find device node %s\n", devnode->name); |
| + of_node_put(devnode); |
| return ERR_PTR(-EPROBE_DEFER); |
| } |
| + of_node_put(devnode); |
| |
| ocmem = platform_get_drvdata(pdev); |
| if (!ocmem) { |
| -- |
| 2.35.1 |
| |