| From ce666be89a8a09c5924ff08fc32e119f974bdab6 Mon Sep 17 00:00:00 2001 |
| From: Alexander Shishkin <alexander.shishkin@linux.intel.com> |
| Date: Tue, 17 Mar 2020 08:22:14 +0200 |
| Subject: intel_th: Fix user-visible error codes |
| |
| From: Alexander Shishkin <alexander.shishkin@linux.intel.com> |
| |
| commit ce666be89a8a09c5924ff08fc32e119f974bdab6 upstream. |
| |
| There are a few places in the driver that end up returning ENOTSUPP to |
| the user, replace those with EINVAL. |
| |
| Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com> |
| Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
| Fixes: ba82664c134ef ("intel_th: Add Memory Storage Unit driver") |
| Cc: stable@vger.kernel.org # v4.4+ |
| Link: https://lore.kernel.org/r/20200317062215.15598-6-alexander.shishkin@linux.intel.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/hwtracing/intel_th/msu.c | 6 +++--- |
| 1 file changed, 3 insertions(+), 3 deletions(-) |
| |
| --- a/drivers/hwtracing/intel_th/msu.c |
| +++ b/drivers/hwtracing/intel_th/msu.c |
| @@ -483,7 +483,7 @@ static int msc_configure(struct msc *msc |
| u32 reg; |
| |
| if (msc->mode > MSC_MODE_MULTI) |
| - return -ENOTSUPP; |
| + return -EINVAL; |
| |
| if (msc->mode == MSC_MODE_MULTI) |
| msc_buffer_clear_hw_header(msc); |
| @@ -935,7 +935,7 @@ static int msc_buffer_alloc(struct msc * |
| } else if (msc->mode == MSC_MODE_MULTI) { |
| ret = msc_buffer_multi_alloc(msc, nr_pages, nr_wins); |
| } else { |
| - ret = -ENOTSUPP; |
| + ret = -EINVAL; |
| } |
| |
| if (!ret) { |
| @@ -1164,7 +1164,7 @@ static ssize_t intel_th_msc_read(struct |
| if (ret >= 0) |
| *ppos = iter->offset; |
| } else { |
| - ret = -ENOTSUPP; |
| + ret = -EINVAL; |
| } |
| |
| put_count: |
