| From foo@baz Mon Jul 3 11:54:13 CEST 2017 |
| From: Eran Ben Elisha <eranbe@mellanox.com> |
| Date: Tue, 17 Jan 2017 19:19:17 +0200 |
| Subject: net: ethtool: Initialize buffer when querying device channel settings |
| |
| From: Eran Ben Elisha <eranbe@mellanox.com> |
| |
| |
| [ Upstream commit 31a86d137219373c3222ca5f4f912e9a4d8065bb ] |
| |
| Ethtool channels respond struct was uninitialized when querying device |
| channel boundaries settings. As a result, unreported fields by the driver |
| hold garbage. This may cause sending unsupported params to driver. |
| |
| Fixes: 8bf368620486 ('ethtool: ensure channel counts are within bounds ...') |
| Signed-off-by: Eran Ben Elisha <eranbe@mellanox.com> |
| Signed-off-by: Tariq Toukan <tariqt@mellanox.com> |
| CC: John W. Linville <linville@tuxdriver.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <alexander.levin@verizon.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| net/core/ethtool.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/net/core/ethtool.c |
| +++ b/net/core/ethtool.c |
| @@ -1704,7 +1704,7 @@ static noinline_for_stack int ethtool_ge |
| static noinline_for_stack int ethtool_set_channels(struct net_device *dev, |
| void __user *useraddr) |
| { |
| - struct ethtool_channels channels, max; |
| + struct ethtool_channels channels, max = { .cmd = ETHTOOL_GCHANNELS }; |
| u32 max_rx_in_use = 0; |
| |
| if (!dev->ethtool_ops->set_channels || !dev->ethtool_ops->get_channels) |
