| From d1a196e0a6dcddd03748468a0e9e3100790fc85c Mon Sep 17 00:00:00 2001 |
| From: Thorsten Blum <thorsten.blum@linux.dev> |
| Date: Tue, 3 Mar 2026 12:30:51 +0100 |
| Subject: platform/x86: dell-wmi-sysman: Don't hex dump plaintext password data |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Thorsten Blum <thorsten.blum@linux.dev> |
| |
| commit d1a196e0a6dcddd03748468a0e9e3100790fc85c upstream. |
| |
| set_new_password() hex dumps the entire buffer, which contains plaintext |
| password data, including current and new passwords. Remove the hex dump |
| to avoid leaking credentials. |
| |
| Fixes: e8a60aa7404b ("platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems") |
| Cc: stable@vger.kernel.org |
| Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> |
| Link: https://patch.msgid.link/20260303113050.58127-2-thorsten.blum@linux.dev |
| Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> |
| Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/platform/x86/dell/dell-wmi-sysman/passwordattr-interface.c | 1 - |
| 1 file changed, 1 deletion(-) |
| |
| --- a/drivers/platform/x86/dell/dell-wmi-sysman/passwordattr-interface.c |
| +++ b/drivers/platform/x86/dell/dell-wmi-sysman/passwordattr-interface.c |
| @@ -93,7 +93,6 @@ int set_new_password(const char *passwor |
| if (ret < 0) |
| goto out; |
| |
| - print_hex_dump_bytes("set new password data: ", DUMP_PREFIX_NONE, buffer, buffer_size); |
| ret = call_password_interface(wmi_priv.password_attr_wdev, buffer, buffer_size); |
| /* on success copy the new password to current password */ |
| if (!ret) |
