| From 9a00c44d86419f99074f1c67aa2c24abbf4a4c68 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sun, 15 Feb 2026 22:04:38 -0600 |
| Subject: drm/tiny: sharp-memory: fix pointer error dereference |
| |
| From: Ethan Tidmore <ethantidmore06@gmail.com> |
| |
| [ Upstream commit 46120745bb4e7e1f09959624716b4c5d6e2c2e9e ] |
| |
| The function devm_drm_dev_alloc() returns a pointer error upon failure |
| not NULL. Change null check to pointer error check. |
| |
| Detected by Smatch: |
| drivers/gpu/drm/tiny/sharp-memory.c:549 sharp_memory_probe() error: |
| 'smd' dereferencing possible ERR_PTR() |
| |
| Fixes: b8f9f21716fec ("drm/tiny: Add driver for Sharp Memory LCD") |
| Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com> |
| Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> |
| Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> |
| Link: https://patch.msgid.link/20260216040438.43702-1-ethantidmore06@gmail.com |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/tiny/sharp-memory.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| diff --git a/drivers/gpu/drm/tiny/sharp-memory.c b/drivers/gpu/drm/tiny/sharp-memory.c |
| index 64272cd0f6e22..cbf69460ebf32 100644 |
| --- a/drivers/gpu/drm/tiny/sharp-memory.c |
| +++ b/drivers/gpu/drm/tiny/sharp-memory.c |
| @@ -541,8 +541,8 @@ static int sharp_memory_probe(struct spi_device *spi) |
| |
| smd = devm_drm_dev_alloc(dev, &sharp_memory_drm_driver, |
| struct sharp_memory_device, drm); |
| - if (!smd) |
| - return -ENOMEM; |
| + if (IS_ERR(smd)) |
| + return PTR_ERR(smd); |
| |
| spi_set_drvdata(spi, smd); |
| |
| -- |
| 2.51.0 |
| |