| From 2e9462fb9c49af348f0234f39e4307a9ec97768a Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 2 Dec 2025 15:57:15 -0800 |
| Subject: perf tools: Fix split kallsyms DSO counting |
| |
| From: Namhyung Kim <namhyung@kernel.org> |
| |
| [ Upstream commit ad0b9c4865b98dc37f4d606d26b1c19808796805 ] |
| |
| It's counted twice as it's increased after calling maps__insert(). I |
| guess we want to increase it only after it's added properly. |
| |
| Reviewed-by: Ian Rogers <irogers@google.com> |
| Fixes: 2e538c4a1847291cf ("perf tools: Improve kernel/modules symbol lookup") |
| Signed-off-by: Namhyung Kim <namhyung@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| tools/perf/util/symbol.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c |
| index 98014f9375686..b434f2398df5a 100644 |
| --- a/tools/perf/util/symbol.c |
| +++ b/tools/perf/util/symbol.c |
| @@ -904,11 +904,11 @@ static int maps__split_kallsyms(struct maps *kmaps, struct dso *dso, u64 delta, |
| if (dso->kernel == DSO_SPACE__KERNEL_GUEST) |
| snprintf(dso_name, sizeof(dso_name), |
| "[guest.kernel].%d", |
| - kernel_range++); |
| + kernel_range); |
| else |
| snprintf(dso_name, sizeof(dso_name), |
| "[kernel].%d", |
| - kernel_range++); |
| + kernel_range); |
| |
| ndso = dso__new(dso_name); |
| if (ndso == NULL) |
| -- |
| 2.51.0 |
| |