| From 6f1d4d2ecfcd1b577dc87350ea965fe81f272e83 Mon Sep 17 00:00:00 2001 |
| From: Arnd Bergmann <arnd@arndb.de> |
| Date: Fri, 22 Mar 2024 14:22:48 +0100 |
| Subject: tpm: avoid -Wunused-but-set-variable |
| |
| From: Arnd Bergmann <arnd@arndb.de> |
| |
| commit 6f1d4d2ecfcd1b577dc87350ea965fe81f272e83 upstream. |
| |
| Outside of the EFI tpm code, the TPM_MEMREMAP()/TPM_MEMUNMAP functions are |
| defined as trivial macros, leading to the mapping_size variable ending |
| up unused: |
| |
| In file included from drivers/char/tpm/tpm-sysfs.c:16: |
| In file included from drivers/char/tpm/tpm.h:28: |
| include/linux/tpm_eventlog.h:167:6: error: variable 'mapping_size' set but not used [-Werror,-Wunused-but-set-variable] |
| 167 | int mapping_size; |
| |
| Turn the stubs into inline functions to avoid this warning. |
| |
| Cc: stable@vger.kernel.org # v5.3+ |
| Fixes: c46f3405692d ("tpm: Reserve the TPM final events table") |
| Signed-off-by: Arnd Bergmann <arnd@arndb.de> |
| Reviewed-by: Thorsten Blum <thorsten.blum@linux.dev> |
| Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> |
| Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| include/linux/tpm_eventlog.h | 9 +++++++-- |
| 1 file changed, 7 insertions(+), 2 deletions(-) |
| |
| --- a/include/linux/tpm_eventlog.h |
| +++ b/include/linux/tpm_eventlog.h |
| @@ -131,11 +131,16 @@ struct tcg_algorithm_info { |
| }; |
| |
| #ifndef TPM_MEMREMAP |
| -#define TPM_MEMREMAP(start, size) NULL |
| +static inline void *TPM_MEMREMAP(unsigned long start, size_t size) |
| +{ |
| + return NULL; |
| +} |
| #endif |
| |
| #ifndef TPM_MEMUNMAP |
| -#define TPM_MEMUNMAP(start, size) do{} while(0) |
| +static inline void TPM_MEMUNMAP(void *mapping, size_t size) |
| +{ |
| +} |
| #endif |
| |
| /** |