| From 453ad06301204bd60bd132733506972f02f986a2 Mon Sep 17 00:00:00 2001 |
| From: Akira Fujita <a-fujita@rs.jp.nec.com> |
| Date: Sat, 5 Sep 2009 22:11:55 -0400 |
| Subject: [PATCH 18/85] ext4: Remove unneeded BUG_ON() in ext4_move_extents() |
| |
| (cherry picked from commit daea696dbac0e33af3cfe304efbfb8d74e0effe6) |
| |
| The ext4_move_extents() functions checks with BUG_ON() whether the |
| exchanged blocks count accords with request blocks count. But, if the |
| target range (orig_start + len) includes sparse block(s), 'moved_len' |
| (exchanged blocks count) does not agree with 'len' (request blocks |
| count), since sparse block is not counted in 'moved_len'. This causes |
| us to hit the BUG_ON(), even though the function succeeded. |
| |
| Signed-off-by: Akira Fujita <a-fujita@rs.jp.nec.com> |
| Signed-off-by: "Theodore Ts'o" <tytso@mit.edu> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| --- |
| fs/ext4/move_extent.c | 3 --- |
| 1 file changed, 3 deletions(-) |
| |
| --- a/fs/ext4/move_extent.c |
| +++ b/fs/ext4/move_extent.c |
| @@ -1322,8 +1322,5 @@ out2: |
| if (ret) |
| return ret; |
| |
| - /* All of the specified blocks must be exchanged in succeed */ |
| - BUG_ON(*moved_len != len); |
| - |
| return 0; |
| } |
