| From b566e782be32145664d96ada3e389f17d32742e5 Mon Sep 17 00:00:00 2001 |
| From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> |
| Date: Fri, 18 Apr 2014 14:19:52 +0200 |
| Subject: bus: mvebu-mbus: allow several windows with the same target/attribute |
| |
| From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> |
| |
| commit b566e782be32145664d96ada3e389f17d32742e5 upstream. |
| |
| Having multiple windows with the same target and attribute is actually |
| legal, and can be useful for PCIe windows, when PCIe BARs have a size |
| that isn't a power of two, and we therefore need to create several |
| MBus windows to cover the PCIe BAR for a given PCIe interface. |
| |
| Fixes: fddddb52a6c4 ('bus: introduce an Marvell EBU MBus driver') |
| Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> |
| Link: https://lkml.kernel.org/r/1397823593-1932-7-git-send-email-thomas.petazzoni@free-electrons.com |
| Tested-by: Neil Greatorex <neil@fatboyfat.co.uk> |
| Signed-off-by: Jason Cooper <jason@lakedaemon.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/bus/mvebu-mbus.c | 6 ------ |
| 1 file changed, 6 deletions(-) |
| |
| --- a/drivers/bus/mvebu-mbus.c |
| +++ b/drivers/bus/mvebu-mbus.c |
| @@ -250,12 +250,6 @@ static int mvebu_mbus_window_conflicts(s |
| */ |
| if ((u64)base < wend && end > wbase) |
| return 0; |
| - |
| - /* |
| - * Check if target/attribute conflicts |
| - */ |
| - if (target == wtarget && attr == wattr) |
| - return 0; |
| } |
| |
| return 1; |