| From 17c048fc4bd95efea208a1920f169547d8588f1f Mon Sep 17 00:00:00 2001 |
| From: Josef Gajdusek <atx@atx.name> |
| Date: Sun, 11 May 2014 14:40:44 +0200 |
| Subject: hwmon: (emc1403) fix inverted store_hyst() |
| |
| From: Josef Gajdusek <atx@atx.name> |
| |
| commit 17c048fc4bd95efea208a1920f169547d8588f1f upstream. |
| |
| Attempts to set the hysteresis value to a temperature below the target |
| limit fails with "write error: Numerical result out of range" due to |
| an inverted comparison. |
| |
| Signed-off-by: Josef Gajdusek <atx@atx.name> |
| Reviewed-by: Jean Delvare <jdelvare@suse.de> |
| [Guenter Roeck: Updated headline and description] |
| Signed-off-by: Guenter Roeck <linux@roeck-us.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/hwmon/emc1403.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/hwmon/emc1403.c |
| +++ b/drivers/hwmon/emc1403.c |
| @@ -162,7 +162,7 @@ static ssize_t store_hyst(struct device |
| if (retval < 0) |
| goto fail; |
| |
| - hyst = val - retval * 1000; |
| + hyst = retval * 1000 - val; |
| hyst = DIV_ROUND_CLOSEST(hyst, 1000); |
| if (hyst < 0 || hyst > 255) { |
| retval = -ERANGE; |
