| From cfece5857ca51d1dcdb157017aba226f594e9dcf Mon Sep 17 00:00:00 2001 |
| From: Guennadi Liakhovetski <g.liakhovetski@gmx.de> |
| Date: Mon, 14 Apr 2014 10:49:34 -0300 |
| Subject: media: V4L2: ov7670: fix a wrong index, potentially Oopsing the kernel from user-space |
| |
| From: Guennadi Liakhovetski <g.liakhovetski@gmx.de> |
| |
| commit cfece5857ca51d1dcdb157017aba226f594e9dcf upstream. |
| |
| Commit 75e2bdad8901a0b599e01a96229be922eef1e488 "ov7670: allow |
| configuration of image size, clock speed, and I/O method" uses a wrong |
| index to iterate an array. Apart from being wrong, it also uses an |
| unchecked value from user-space, which can cause access to unmapped |
| memory in the kernel, triggered by a normal desktop user with rights to |
| use V4L2 devices. |
| |
| Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> |
| Acked-by: Jonathan Corbet <corbet@lwn.net> |
| Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/media/i2c/ov7670.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/media/i2c/ov7670.c |
| +++ b/drivers/media/i2c/ov7670.c |
| @@ -1110,7 +1110,7 @@ static int ov7670_enum_framesizes(struct |
| * windows that fall outside that. |
| */ |
| for (i = 0; i < n_win_sizes; i++) { |
| - struct ov7670_win_size *win = &info->devtype->win_sizes[index]; |
| + struct ov7670_win_size *win = &info->devtype->win_sizes[i]; |
| if (info->min_width && win->width < info->min_width) |
| continue; |
| if (info->min_height && win->height < info->min_height) |
