| From f8d7b13e14357ed19d2ca2799539600418dc3939 Mon Sep 17 00:00:00 2001 |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| Date: Fri, 13 Sep 2013 10:52:14 +0300 |
| Subject: ASoC: max98095: a couple array underflows |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| commit f8d7b13e14357ed19d2ca2799539600418dc3939 upstream. |
| |
| The ->put() function are called from snd_ctl_elem_write() with user |
| supplied data. The limit checks here could underflow leading to a |
| crash. |
| |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Mark Brown <broonie@linaro.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| sound/soc/codecs/max98095.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/sound/soc/codecs/max98095.c |
| +++ b/sound/soc/codecs/max98095.c |
| @@ -1863,7 +1863,7 @@ static int max98095_put_eq_enum(struct s |
| struct max98095_pdata *pdata = max98095->pdata; |
| int channel = max98095_get_eq_channel(kcontrol->id.name); |
| struct max98095_cdata *cdata; |
| - int sel = ucontrol->value.integer.value[0]; |
| + unsigned int sel = ucontrol->value.integer.value[0]; |
| struct max98095_eq_cfg *coef_set; |
| int fs, best, best_val, i; |
| int regmask, regsave; |
| @@ -2016,7 +2016,7 @@ static int max98095_put_bq_enum(struct s |
| struct max98095_pdata *pdata = max98095->pdata; |
| int channel = max98095_get_bq_channel(codec, kcontrol->id.name); |
| struct max98095_cdata *cdata; |
| - int sel = ucontrol->value.integer.value[0]; |
| + unsigned int sel = ucontrol->value.integer.value[0]; |
| struct max98095_biquad_cfg *coef_set; |
| int fs, best, best_val, i; |
| int regmask, regsave; |
