| From bd99f85135b8267dd8a8df8671bb5ac6ae1e228d Mon Sep 17 00:00:00 2001 |
| From: Wenwen Wang <wenwen@cs.uga.edu> |
| Date: Sun, 14 Jul 2019 01:11:35 -0500 |
| Subject: test_firmware: fix a memory leak bug |
| |
| [ Upstream commit d4fddac5a51c378c5d3e68658816c37132611e1f ] |
| |
| In test_firmware_init(), the buffer pointed to by the global pointer |
| 'test_fw_config' is allocated through kzalloc(). Then, the buffer is |
| initialized in __test_firmware_config_init(). In the case that the |
| initialization fails, the following execution in test_firmware_init() needs |
| to be terminated with an error code returned to indicate this failure. |
| However, the allocated buffer is not freed on this execution path, leading |
| to a memory leak bug. |
| |
| To fix the above issue, free the allocated buffer before returning from |
| test_firmware_init(). |
| |
| Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu> |
| Link: https://lore.kernel.org/r/1563084696-6865-1-git-send-email-wang6495@umn.edu |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| lib/test_firmware.c | 5 ++++- |
| 1 file changed, 4 insertions(+), 1 deletion(-) |
| |
| diff --git a/lib/test_firmware.c b/lib/test_firmware.c |
| index f978aebe60c5b..2e5e18bbfd28e 100644 |
| --- a/lib/test_firmware.c |
| +++ b/lib/test_firmware.c |
| @@ -895,8 +895,11 @@ static int __init test_firmware_init(void) |
| return -ENOMEM; |
| |
| rc = __test_firmware_config_init(); |
| - if (rc) |
| + if (rc) { |
| + kfree(test_fw_config); |
| + pr_err("could not init firmware test config: %d\n", rc); |
| return rc; |
| + } |
| |
| rc = misc_register(&test_fw_misc_device); |
| if (rc) { |
| -- |
| 2.20.1 |
| |
