| From ba634eceb535d95e87ef09caae7814b3687c6036 Mon Sep 17 00:00:00 2001 |
| From: Masahiro Yamada <yamada.masahiro@socionext.com> |
| Date: Wed, 4 Oct 2017 12:56:05 +0900 |
| Subject: kbuild: move "_all" target out of $(KBUILD_SRC) conditional |
| |
| From: Masahiro Yamada <yamada.masahiro@socionext.com> |
| |
| commit ba634eceb535d95e87ef09caae7814b3687c6036 upstream. |
| |
| The first "_all" occurrence around line 120 is only visible when |
| KBUILD_SRC is unset. |
| |
| If O=... is specified, the working directory is relocated, then the |
| only second occurrence around line 193 is visible, that is not set |
| to PHONY. |
| |
| Move the first one to an always visible place. This clarifies "_all" |
| is our default target and it is always set to PHONY. |
| |
| Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> |
| Reviewed-by: Douglas Anderson <dianders@chromium.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| Makefile | 8 ++++---- |
| 1 file changed, 4 insertions(+), 4 deletions(-) |
| |
| --- a/Makefile |
| +++ b/Makefile |
| @@ -11,6 +11,10 @@ NAME = Petit Gorille |
| # Comments in this file are targeted only to the developer, do not |
| # expect to learn how to build the kernel reading this file. |
| |
| +# That's our default target when none is given on the command line |
| +PHONY := _all |
| +_all: |
| + |
| # o Do not use make's built-in rules and variables |
| # (this increases performance and avoids hard-to-debug behaviour); |
| # o Look for make include files relative to root of kernel src |
| @@ -117,10 +121,6 @@ ifeq ("$(origin O)", "command line") |
| KBUILD_OUTPUT := $(O) |
| endif |
| |
| -# That's our default target when none is given on the command line |
| -PHONY := _all |
| -_all: |
| - |
| # Cancel implicit rules on top Makefile |
| $(CURDIR)/Makefile Makefile: ; |
| |
