| From 5d3300a9b8b122b4743aed5a178bf12c87e2b8c9 Mon Sep 17 00:00:00 2001 |
| From: Giridhar Malavali <giridhar.malavali@cavium.com> |
| Date: Mon, 4 Dec 2017 14:45:13 -0800 |
| Subject: scsi: qla2xxx: Defer processing of GS IOCB calls |
| |
| From: Giridhar Malavali <giridhar.malavali@cavium.com> |
| |
| commit 5d3300a9b8b122b4743aed5a178bf12c87e2b8c9 upstream. |
| |
| This patch defers processing of GS IOCB calls from interrupt context to |
| avoid hardware spinlock recursion. |
| |
| Following stack trace is seen |
| |
| ? mod_timer+0x193/0x330 |
| ? ql_dbg+0xa7/0xf0 [qla2xxx] |
| _raw_spin_lock_irqsave+0x31/0x40 |
| qla2x00_start_sp+0x3b/0x250 [qla2xxx] |
| qla24xx_async_gnl+0x1d3/0x240 [qla2xxx] |
| qla24xx_fcport_handle_login+0x285/0x290 [qla2xxx] |
| ? vprintk_func+0x20/0x50 |
| |
| Fixes: 726b85487067d ("qla2xxx: Add framework for async fabric discovery") |
| Cc: <stable@vger.kernel.org> # 4.10+ |
| Signed-off-by: Giridhar Malavali <giridhar.malavali@cavium.com> |
| Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com> |
| Reviewed-by: Hannes Reinecke <hare@suse.com> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/scsi/qla2xxx/qla_init.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/drivers/scsi/qla2xxx/qla_init.c |
| +++ b/drivers/scsi/qla2xxx/qla_init.c |
| @@ -973,7 +973,7 @@ int qla24xx_fcport_handle_login(struct s |
| ql_dbg(ql_dbg_disc, vha, 0x20bd, |
| "%s %d %8phC post gnl\n", |
| __func__, __LINE__, fcport->port_name); |
| - qla24xx_async_gnl(vha, fcport); |
| + qla24xx_post_gnl_work(vha, fcport); |
| } else { |
| ql_dbg(ql_dbg_disc, vha, 0x20bf, |
| "%s %d %8phC post login\n", |
| @@ -1142,7 +1142,7 @@ void qla24xx_handle_relogin_event(scsi_q |
| ql_dbg(ql_dbg_disc, vha, 0x20e9, "%s %d %8phC post gidpn\n", |
| __func__, __LINE__, fcport->port_name); |
| |
| - qla24xx_async_gidpn(vha, fcport); |
| + qla24xx_post_gidpn_work(vha, fcport); |
| return; |
| } |
| |
