| From 23c645595dab7b414f23639d0a428a07515807df Mon Sep 17 00:00:00 2001 |
| From: Quinn Tran <quinn.tran@cavium.com> |
| Date: Mon, 4 Dec 2017 14:45:08 -0800 |
| Subject: scsi: qla2xxx: Fix PRLI state check |
| |
| From: Quinn Tran <quinn.tran@cavium.com> |
| |
| commit 23c645595dab7b414f23639d0a428a07515807df upstream. |
| |
| Get Port Database MBX cmd is to validate current Login state upon PRLI |
| completion. Current code looks at the last login state for re-validation |
| which was incorrect. This patch removed incorrect state check. |
| |
| Fixes: 15f30a5752287 ("qla2xxx: Use IOCB interface to submit non-critical MBX.") |
| Cc: <stable@vger.kernel.org> # 4.10+ |
| Signed-off-by: Quinn Tran <quinn.tran@cavium.com> |
| Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com> |
| Reviewed-by: Hannes Reinecke <hare@suse.com> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/scsi/qla2xxx/qla_mbx.c | 3 +-- |
| 1 file changed, 1 insertion(+), 2 deletions(-) |
| |
| --- a/drivers/scsi/qla2xxx/qla_mbx.c |
| +++ b/drivers/scsi/qla2xxx/qla_mbx.c |
| @@ -6078,8 +6078,7 @@ int __qla24xx_parse_gpdb(struct scsi_qla |
| } |
| |
| /* Check for logged in state. */ |
| - if (current_login_state != PDS_PRLI_COMPLETE && |
| - last_login_state != PDS_PRLI_COMPLETE) { |
| + if (current_login_state != PDS_PRLI_COMPLETE) { |
| ql_dbg(ql_dbg_mbx, vha, 0x119a, |
| "Unable to verify login-state (%x/%x) for loop_id %x.\n", |
| current_login_state, last_login_state, fcport->loop_id); |