| From foo@baz Fri Mar 16 15:43:17 CET 2018 |
| From: Colin Ian King <colin.king@canonical.com> |
| Date: Wed, 15 Nov 2017 12:37:19 +0000 |
| Subject: crypto: cavium - fix memory leak on info |
| |
| From: Colin Ian King <colin.king@canonical.com> |
| |
| |
| [ Upstream commit 87aae50af730a28dc1d8846d86dca5e9aa724a9f ] |
| |
| The object info is being leaked on an error return path, fix this |
| by setting ret to -ENOMEM and exiting via the request_cleanup path |
| that will free info. |
| |
| Detected by CoverityScan, CID#1408439 ("Resource Leak") |
| |
| Fixes: c694b233295b ("crypto: cavium - Add the Virtual Function driver for CPT") |
| Signed-off-by: Colin Ian King <colin.king@canonical.com> |
| Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/crypto/cavium/cpt/cptvf_reqmanager.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/crypto/cavium/cpt/cptvf_reqmanager.c |
| +++ b/drivers/crypto/cavium/cpt/cptvf_reqmanager.c |
| @@ -459,7 +459,8 @@ int process_request(struct cpt_vf *cptvf |
| info->completion_addr = kzalloc(sizeof(union cpt_res_s), GFP_KERNEL); |
| if (unlikely(!info->completion_addr)) { |
| dev_err(&pdev->dev, "Unable to allocate memory for completion_addr\n"); |
| - return -ENOMEM; |
| + ret = -ENOMEM; |
| + goto request_cleanup; |
| } |
| |
| result = (union cpt_res_s *)info->completion_addr; |
