| From foo@baz Fri Mar 16 15:43:17 CET 2018 |
| From: Luca Coelho <luciano.coelho@intel.com> |
| Date: Sun, 29 Oct 2017 11:51:10 +0200 |
| Subject: mac80211: remove BUG() when interface type is invalid |
| |
| From: Luca Coelho <luciano.coelho@intel.com> |
| |
| |
| [ Upstream commit c7976f5272486e4ff406014c4b43e2fa3b70b052 ] |
| |
| In the ieee80211_setup_sdata() we check if the interface type is valid |
| and, if not, call BUG(). This should never happen, but if there is |
| something wrong with the code, it will not be caught until the bug |
| happens when an interface is being set up. Calling BUG() is too |
| extreme for this and a WARN_ON() would be better used instead. Change |
| that. |
| |
| Signed-off-by: Luca Coelho <luciano.coelho@intel.com> |
| Signed-off-by: Johannes Berg <johannes.berg@intel.com> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| net/mac80211/iface.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/net/mac80211/iface.c |
| +++ b/net/mac80211/iface.c |
| @@ -1493,7 +1493,7 @@ static void ieee80211_setup_sdata(struct |
| break; |
| case NL80211_IFTYPE_UNSPECIFIED: |
| case NUM_NL80211_IFTYPES: |
| - BUG(); |
| + WARN_ON(1); |
| break; |
| } |
| |
