| From 4d77a89e3924b12f4a5628b21237e57ab4703866 Mon Sep 17 00:00:00 2001 |
| From: =?UTF-8?q?Michael=20B=C3=BCsch?= <m@bues.ch> |
| Date: Tue, 31 Jul 2018 21:14:16 +0200 |
| Subject: b43legacy/leds: Ensure NUL-termination of LED name string |
| |
| From: Michael Buesch <m@bues.ch> |
| |
| commit 4d77a89e3924b12f4a5628b21237e57ab4703866 upstream. |
| |
| strncpy might not NUL-terminate the string, if the name equals the buffer size. |
| Use strlcpy instead. |
| |
| Signed-off-by: Michael Buesch <m@bues.ch> |
| Cc: stable@vger.kernel.org |
| Signed-off-by: Kalle Valo <kvalo@codeaurora.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/net/wireless/broadcom/b43legacy/leds.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/net/wireless/broadcom/b43legacy/leds.c |
| +++ b/drivers/net/wireless/broadcom/b43legacy/leds.c |
| @@ -101,7 +101,7 @@ static int b43legacy_register_led(struct |
| led->dev = dev; |
| led->index = led_index; |
| led->activelow = activelow; |
| - strncpy(led->name, name, sizeof(led->name)); |
| + strlcpy(led->name, name, sizeof(led->name)); |
| |
| led->led_dev.name = led->name; |
| led->led_dev.default_trigger = default_trigger; |
