| From foo@baz Sun Aug 26 09:13:00 CEST 2018 |
| From: Colin Ian King <colin.king@canonical.com> |
| Date: Wed, 1 Aug 2018 18:22:41 +0100 |
| Subject: drivers: net: lmc: fix case value for target abort error |
| |
| From: Colin Ian King <colin.king@canonical.com> |
| |
| [ Upstream commit afb41bb039656f0cecb54eeb8b2e2088201295f5 ] |
| |
| Current value for a target abort error is 0x010, however, this value |
| should in fact be 0x002. As it stands, the range of error is 0..7 so |
| it is currently never being detected. This bug has been in the driver |
| since the early 2.6.12 days (or before). |
| |
| Detected by CoverityScan, CID#744290 ("Logically dead code") |
| |
| Signed-off-by: Colin Ian King <colin.king@canonical.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/wan/lmc/lmc_main.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/net/wan/lmc/lmc_main.c |
| +++ b/drivers/net/wan/lmc/lmc_main.c |
| @@ -1371,7 +1371,7 @@ static irqreturn_t lmc_interrupt (int ir |
| case 0x001: |
| printk(KERN_WARNING "%s: Master Abort (naughty)\n", dev->name); |
| break; |
| - case 0x010: |
| + case 0x002: |
| printk(KERN_WARNING "%s: Target Abort (not so naughty)\n", dev->name); |
| break; |
| default: |
