| From db7ddef301128dad394f1c0f77027f86ee9a4edb Mon Sep 17 00:00:00 2001 |
| From: Nicholas Piggin <npiggin@gmail.com> |
| Date: Thu, 23 Aug 2018 18:47:08 +1000 |
| Subject: mm: move tlb_table_flush to tlb_flush_mmu_free |
| |
| From: Nicholas Piggin <npiggin@gmail.com> |
| |
| commit db7ddef301128dad394f1c0f77027f86ee9a4edb upstream. |
| |
| There is no need to call this from tlb_flush_mmu_tlbonly, it logically |
| belongs with tlb_flush_mmu_free. This makes future fixes simpler. |
| |
| [ This was originally done to allow code consolidation for the |
| mmu_notifier fix, but it also ends up helping simplify the |
| HAVE_RCU_TABLE_INVALIDATE fix. - Linus ] |
| |
| Signed-off-by: Nicholas Piggin <npiggin@gmail.com> |
| Acked-by: Will Deacon <will.deacon@arm.com> |
| Cc: Peter Zijlstra <peterz@infradead.org> |
| Cc: stable@kernel.org |
| Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| mm/memory.c | 6 +++--- |
| 1 file changed, 3 insertions(+), 3 deletions(-) |
| |
| --- a/mm/memory.c |
| +++ b/mm/memory.c |
| @@ -246,9 +246,6 @@ static void tlb_flush_mmu_tlbonly(struct |
| |
| tlb_flush(tlb); |
| mmu_notifier_invalidate_range(tlb->mm, tlb->start, tlb->end); |
| -#ifdef CONFIG_HAVE_RCU_TABLE_FREE |
| - tlb_table_flush(tlb); |
| -#endif |
| __tlb_reset_range(tlb); |
| } |
| |
| @@ -256,6 +253,9 @@ static void tlb_flush_mmu_free(struct mm |
| { |
| struct mmu_gather_batch *batch; |
| |
| +#ifdef CONFIG_HAVE_RCU_TABLE_FREE |
| + tlb_table_flush(tlb); |
| +#endif |
| for (batch = &tlb->local; batch && batch->nr; batch = batch->next) { |
| free_pages_and_swap_cache(batch->pages, batch->nr); |
| batch->nr = 0; |