| From 19da44cd33a3a6ff7c97fff0189999ff15b241e4 Mon Sep 17 00:00:00 2001 |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| Date: Fri, 13 Jul 2018 17:55:15 +0300 |
| Subject: pinctrl: freescale: off by one in imx1_pinconf_group_dbg_show() |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| commit 19da44cd33a3a6ff7c97fff0189999ff15b241e4 upstream. |
| |
| The info->groups[] array is allocated in imx1_pinctrl_parse_dt(). It |
| has info->ngroups elements. Thus the > here should be >= to prevent |
| reading one element beyond the end of the array. |
| |
| Cc: stable@vger.kernel.org |
| Fixes: 30612cd90005 ("pinctrl: imx1 core driver") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Reviewed-by: Uwe Kleine-König <u.kleine-könig@pengutronix.de> |
| Acked-by: Dong Aisheng <Aisheng.dong@nxp.com> |
| Signed-off-by: Linus Walleij <linus.walleij@linaro.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/pinctrl/freescale/pinctrl-imx1-core.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/pinctrl/freescale/pinctrl-imx1-core.c |
| +++ b/drivers/pinctrl/freescale/pinctrl-imx1-core.c |
| @@ -433,7 +433,7 @@ static void imx1_pinconf_group_dbg_show( |
| const char *name; |
| int i, ret; |
| |
| - if (group > info->ngroups) |
| + if (group >= info->ngroups) |
| return; |
| |
| seq_puts(s, "\n"); |
