| From d79cddeecd121ce1dfed77f1a1eaaa2e1d3b43a9 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 15 Jun 2020 00:49:28 -0500 |
| Subject: drm/exynos: fix ref count leak in mic_pre_enable |
| |
| From: Navid Emamdoost <navid.emamdoost@gmail.com> |
| |
| [ Upstream commit d4f5a095daf0d25f0b385e1ef26338608433a4c5 ] |
| |
| in mic_pre_enable, pm_runtime_get_sync is called which |
| increments the counter even in case of failure, leading to incorrect |
| ref count. In case of failure, decrement the ref count before returning. |
| |
| Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> |
| Signed-off-by: Inki Dae <inki.dae@samsung.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/exynos/exynos_drm_mic.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c |
| index 2fd299a58297e..cd5530bbfe2e6 100644 |
| --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c |
| +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c |
| @@ -267,8 +267,10 @@ static void mic_pre_enable(struct drm_bridge *bridge) |
| goto unlock; |
| |
| ret = pm_runtime_get_sync(mic->dev); |
| - if (ret < 0) |
| + if (ret < 0) { |
| + pm_runtime_put_noidle(mic->dev); |
| goto unlock; |
| + } |
| |
| mic_set_path(mic, 1); |
| |
| -- |
| 2.25.1 |
| |
