| From 67a7657bdcf26771d0207bf3d8e0476aa8e20795 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 16 Nov 2020 09:09:29 +0800 |
| Subject: drm/sun4i: dw-hdmi: fix error return code in sun8i_dw_hdmi_bind() |
| |
| From: Xiongfeng Wang <wangxiongfeng2@huawei.com> |
| |
| [ Upstream commit 6654b57866b98230a270953dd34f67de17ab1708 ] |
| |
| Fix to return a negative error code from the error handling case instead |
| of 0 in function sun8i_dw_hdmi_bind(). |
| |
| Fixes: b7c7436a5ff0 ("drm/sun4i: Implement A83T HDMI driver") |
| Reported-by: Hulk Robot <hulkci@huawei.com> |
| Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com> |
| Reviewed-by: Jernej Skrabec <jernej.skrabec@siol.net> |
| Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> |
| Link: https://patchwork.freedesktop.org/patch/msgid/1605488969-5211-1-git-send-email-wangxiongfeng2@huawei.com |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c |
| index 31875b636434a..5073622cbb567 100644 |
| --- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c |
| +++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c |
| @@ -140,6 +140,7 @@ static int sun8i_dw_hdmi_bind(struct device *dev, struct device *master, |
| phy_node = of_parse_phandle(dev->of_node, "phys", 0); |
| if (!phy_node) { |
| dev_err(dev, "Can't found PHY phandle\n"); |
| + ret = -EINVAL; |
| goto err_disable_clk_tmds; |
| } |
| |
| -- |
| 2.27.0 |
| |