| From 2dcff99bf04ed4308c242d313a0e7e0bc4d7be1c Mon Sep 17 00:00:00 2001 |
| From: "Tobin C. Harding" <tobin@kernel.org> |
| Date: Tue, 30 Apr 2019 10:11:44 +1000 |
| Subject: sched/cpufreq: Fix kobject memleak |
| |
| [ Upstream commit 9a4f26cc98d81b67ecc23b890c28e2df324e29f3 ] |
| |
| Currently the error return path from kobject_init_and_add() is not |
| followed by a call to kobject_put() - which means we are leaking |
| the kobject. |
| |
| Fix it by adding a call to kobject_put() in the error path of |
| kobject_init_and_add(). |
| |
| Signed-off-by: Tobin C. Harding <tobin@kernel.org> |
| Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Cc: Linus Torvalds <torvalds@linux-foundation.org> |
| Cc: Peter Zijlstra <peterz@infradead.org> |
| Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> |
| Cc: Thomas Gleixner <tglx@linutronix.de> |
| Cc: Tobin C. Harding <tobin@kernel.org> |
| Cc: Vincent Guittot <vincent.guittot@linaro.org> |
| Cc: Viresh Kumar <viresh.kumar@linaro.org> |
| Link: http://lkml.kernel.org/r/20190430001144.24890-1-tobin@kernel.org |
| Signed-off-by: Ingo Molnar <mingo@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| kernel/sched/cpufreq_schedutil.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c |
| index 217f81ecae176..4e3625109b28d 100644 |
| --- a/kernel/sched/cpufreq_schedutil.c |
| +++ b/kernel/sched/cpufreq_schedutil.c |
| @@ -751,6 +751,7 @@ out: |
| return 0; |
| |
| fail: |
| + kobject_put(&tunables->attr_set.kobj); |
| policy->governor_data = NULL; |
| sugov_tunables_free(tunables); |
| |
| -- |
| 2.20.1 |
| |