| From 210782038b54ec8e9059a3c12d6f6ae173efa3a9 Mon Sep 17 00:00:00 2001 |
| From: Colin Ian King <colin.king@canonical.com> |
| Date: Fri, 17 May 2019 09:12:33 +0100 |
| Subject: cifs: fix memory leak of pneg_inbuf on -EOPNOTSUPP ioctl case |
| |
| From: Colin Ian King <colin.king@canonical.com> |
| |
| commit 210782038b54ec8e9059a3c12d6f6ae173efa3a9 upstream. |
| |
| Currently in the case where SMB2_ioctl returns the -EOPNOTSUPP error |
| there is a memory leak of pneg_inbuf. Fix this by returning via |
| the out_free_inbuf exit path that will perform the relevant kfree. |
| |
| Addresses-Coverity: ("Resource leak") |
| Fixes: 969ae8e8d4ee ("cifs: Accept validate negotiate if server return NT_STATUS_NOT_SUPPORTED") |
| CC: Stable <stable@vger.kernel.org> # v5.1+ |
| Signed-off-by: Colin Ian King <colin.king@canonical.com> |
| Signed-off-by: Steve French <stfrench@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| fs/cifs/smb2pdu.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| --- a/fs/cifs/smb2pdu.c |
| +++ b/fs/cifs/smb2pdu.c |
| @@ -887,7 +887,8 @@ int smb3_validate_negotiate(const unsign |
| * not supported error. Client should accept it. |
| */ |
| cifs_dbg(VFS, "Server does not support validate negotiate\n"); |
| - return 0; |
| + rc = 0; |
| + goto out_free_inbuf; |
| } else if (rc != 0) { |
| cifs_dbg(VFS, "validate protocol negotiate failed: %d\n", rc); |
| rc = -EIO; |
