| From 60f2208699ec08ff9fdf1f97639a661a92a18f1c Mon Sep 17 00:00:00 2001 |
| From: Ruslan Babayev <ruslan@babayev.com> |
| Date: Sun, 5 May 2019 12:24:37 -0700 |
| Subject: iio: dac: ds4422/ds4424 fix chip verification |
| |
| From: Ruslan Babayev <ruslan@babayev.com> |
| |
| commit 60f2208699ec08ff9fdf1f97639a661a92a18f1c upstream. |
| |
| The ds4424_get_value function takes channel number as it's 3rd |
| argument and translates it internally into I2C address using |
| DS4424_DAC_ADDR macro. The caller ds4424_verify_chip was passing an |
| already translated I2C address as its last argument. |
| |
| Signed-off-by: Ruslan Babayev <ruslan@babayev.com> |
| Cc: xe-linux-external@cisco.com |
| Cc: <Stable@vger.kernel.org> |
| Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/iio/dac/ds4424.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/iio/dac/ds4424.c |
| +++ b/drivers/iio/dac/ds4424.c |
| @@ -166,7 +166,7 @@ static int ds4424_verify_chip(struct iio |
| { |
| int ret, val; |
| |
| - ret = ds4424_get_value(indio_dev, &val, DS4424_DAC_ADDR(0)); |
| + ret = ds4424_get_value(indio_dev, &val, 0); |
| if (ret < 0) |
| dev_err(&indio_dev->dev, |
| "%s failed. ret: %d\n", __func__, ret); |
