| From 5d24f455c182d5116dd5db8e1dc501115ecc9c2c Mon Sep 17 00:00:00 2001 |
| From: Joe Burmeister <joe.burmeister@devtank.co.uk> |
| Date: Mon, 13 May 2019 11:23:57 +0100 |
| Subject: tty: max310x: Fix external crystal register setup |
| |
| From: Joe Burmeister <joe.burmeister@devtank.co.uk> |
| |
| commit 5d24f455c182d5116dd5db8e1dc501115ecc9c2c upstream. |
| |
| The datasheet states: |
| |
| Bit 4: ClockEnSet the ClockEn bit high to enable an external clocking |
| (crystal or clock generator at XIN). Set the ClockEn bit to 0 to disable |
| clocking |
| Bit 1: CrystalEnSet the CrystalEn bit high to enable the crystal |
| oscillator. When using an external clock source at XIN, CrystalEn must |
| be set low. |
| |
| The bit 4, MAX310X_CLKSRC_EXTCLK_BIT, should be set and was not. |
| |
| This was required to make the MAX3107 with an external crystal on our |
| board able to send or receive data. |
| |
| Signed-off-by: Joe Burmeister <joe.burmeister@devtank.co.uk> |
| Cc: stable <stable@vger.kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/tty/serial/max310x.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/tty/serial/max310x.c |
| +++ b/drivers/tty/serial/max310x.c |
| @@ -576,7 +576,7 @@ static int max310x_set_ref_clk(struct de |
| } |
| |
| /* Configure clock source */ |
| - clksrc = xtal ? MAX310X_CLKSRC_CRYST_BIT : MAX310X_CLKSRC_EXTCLK_BIT; |
| + clksrc = MAX310X_CLKSRC_EXTCLK_BIT | (xtal ? MAX310X_CLKSRC_CRYST_BIT : 0); |
| |
| /* Configure PLL */ |
| if (pllcfg) { |
