| From ed596a4a88bd161f868ccba078557ee7ede8a6ef Mon Sep 17 00:00:00 2001 |
| From: Oliver Neukum <oneukum@suse.com> |
| Date: Tue, 31 May 2016 14:48:15 +0200 |
| Subject: HID: elo: kill not flush the work |
| |
| From: Oliver Neukum <oneukum@suse.com> |
| |
| commit ed596a4a88bd161f868ccba078557ee7ede8a6ef upstream. |
| |
| Flushing a work that reschedules itself is not a sensible operation. It needs |
| to be killed. Failure to do so leads to a kernel panic in the timer code. |
| |
| Signed-off-by: Oliver Neukum <ONeukum@suse.com> |
| Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> |
| Signed-off-by: Jiri Kosina <jkosina@suse.cz> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/hid/hid-elo.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/hid/hid-elo.c |
| +++ b/drivers/hid/hid-elo.c |
| @@ -261,7 +261,7 @@ static void elo_remove(struct hid_device |
| struct elo_priv *priv = hid_get_drvdata(hdev); |
| |
| hid_hw_stop(hdev); |
| - flush_workqueue(wq); |
| + cancel_delayed_work_sync(&priv->work); |
| kfree(priv); |
| } |
| |
