| From 8c5122e45a10a9262f872b53f151a592e870f905 Mon Sep 17 00:00:00 2001 |
| From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> |
| Date: Wed, 8 Jun 2016 17:28:29 -0600 |
| Subject: IB/mlx4: Properly initialize GRH TClass and FlowLabel in AHs |
| |
| From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> |
| |
| commit 8c5122e45a10a9262f872b53f151a592e870f905 upstream. |
| |
| When this code was reworked for IBoE support the order of assignments |
| for the sl_tclass_flowlabel got flipped around resulting in |
| TClass & FlowLabel being permanently set to 0 in the packet headers. |
| |
| This breaks IB routers that rely on these headers, but only affects |
| kernel users - libmlx4 does this properly for user space. |
| |
| Fixes: fa417f7b520e ("IB/mlx4: Add support for IBoE") |
| Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> |
| Signed-off-by: Doug Ledford <dledford@redhat.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/infiniband/hw/mlx4/ah.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/infiniband/hw/mlx4/ah.c |
| +++ b/drivers/infiniband/hw/mlx4/ah.c |
| @@ -47,6 +47,7 @@ static struct ib_ah *create_ib_ah(struct |
| |
| ah->av.ib.port_pd = cpu_to_be32(to_mpd(pd)->pdn | (ah_attr->port_num << 24)); |
| ah->av.ib.g_slid = ah_attr->src_path_bits; |
| + ah->av.ib.sl_tclass_flowlabel = cpu_to_be32(ah_attr->sl << 28); |
| if (ah_attr->ah_flags & IB_AH_GRH) { |
| ah->av.ib.g_slid |= 0x80; |
| ah->av.ib.gid_index = ah_attr->grh.sgid_index; |
| @@ -64,7 +65,6 @@ static struct ib_ah *create_ib_ah(struct |
| !(1 << ah->av.ib.stat_rate & dev->caps.stat_rate_support)) |
| --ah->av.ib.stat_rate; |
| } |
| - ah->av.ib.sl_tclass_flowlabel = cpu_to_be32(ah_attr->sl << 28); |
| |
| return &ah->ibah; |
| } |
