| From ef3149eb3ddb7f9125e11c90f8330e371b55cffd Mon Sep 17 00:00:00 2001 |
| From: Luis de Bethencourt <luisbg@osg.samsung.com> |
| Date: Wed, 22 Jun 2016 20:43:30 +0100 |
| Subject: staging: iio: accel: fix error check |
| |
| From: Luis de Bethencourt <luisbg@osg.samsung.com> |
| |
| commit ef3149eb3ddb7f9125e11c90f8330e371b55cffd upstream. |
| |
| sca3000_read_ctrl_reg() returns a negative number on failure, check for |
| this instead of zero. |
| |
| Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> |
| Signed-off-by: Jonathan Cameron <jic23@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/staging/iio/accel/sca3000_core.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/staging/iio/accel/sca3000_core.c |
| +++ b/drivers/staging/iio/accel/sca3000_core.c |
| @@ -595,7 +595,7 @@ static ssize_t sca3000_read_frequency(st |
| goto error_ret_mut; |
| ret = sca3000_read_ctrl_reg(st, SCA3000_REG_CTRL_SEL_OUT_CTRL); |
| mutex_unlock(&st->lock); |
| - if (ret) |
| + if (ret < 0) |
| goto error_ret; |
| val = ret; |
| if (base_freq > 0) |
