| From foo@baz Wed Aug 22 09:42:09 CEST 2018 |
| From: Stefan Agner <stefan@agner.ch> |
| Date: Sun, 17 Jun 2018 23:40:53 +0200 |
| Subject: net: hamradio: use eth_broadcast_addr |
| |
| From: Stefan Agner <stefan@agner.ch> |
| |
| [ Upstream commit 4e8439aa34802deab11cee68b0ecb18f887fb153 ] |
| |
| The array bpq_eth_addr is only used to get the size of an |
| address, whereas the bcast_addr is used to set the broadcast |
| address. This leads to a warning when using clang: |
| drivers/net/hamradio/bpqether.c:94:13: warning: variable 'bpq_eth_addr' is not |
| needed and will not be emitted [-Wunneeded-internal-declaration] |
| static char bpq_eth_addr[6]; |
| ^ |
| |
| Remove both variables and use the common eth_broadcast_addr |
| to set the broadcast address. |
| |
| Signed-off-by: Stefan Agner <stefan@agner.ch> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/hamradio/bpqether.c | 8 ++------ |
| 1 file changed, 2 insertions(+), 6 deletions(-) |
| |
| --- a/drivers/net/hamradio/bpqether.c |
| +++ b/drivers/net/hamradio/bpqether.c |
| @@ -89,10 +89,6 @@ |
| static const char banner[] __initconst = KERN_INFO \ |
| "AX.25: bpqether driver version 004\n"; |
| |
| -static char bcast_addr[6]={0xFF,0xFF,0xFF,0xFF,0xFF,0xFF}; |
| - |
| -static char bpq_eth_addr[6]; |
| - |
| static int bpq_rcv(struct sk_buff *, struct net_device *, struct packet_type *, struct net_device *); |
| static int bpq_device_event(struct notifier_block *, unsigned long, void *); |
| |
| @@ -515,8 +511,8 @@ static int bpq_new_device(struct net_dev |
| bpq->ethdev = edev; |
| bpq->axdev = ndev; |
| |
| - memcpy(bpq->dest_addr, bcast_addr, sizeof(bpq_eth_addr)); |
| - memcpy(bpq->acpt_addr, bcast_addr, sizeof(bpq_eth_addr)); |
| + eth_broadcast_addr(bpq->dest_addr); |
| + eth_broadcast_addr(bpq->acpt_addr); |
| |
| err = register_netdevice(ndev); |
| if (err) |
