| From foo@baz Wed Aug 22 09:42:09 CEST 2018 |
| From: Stefan Wahren <stefan.wahren@i2se.com> |
| Date: Wed, 18 Jul 2018 08:31:45 +0200 |
| Subject: net: qca_spi: Fix log level if probe fails |
| |
| From: Stefan Wahren <stefan.wahren@i2se.com> |
| |
| [ Upstream commit 50973993260a6934f0a00da53d9b746cfbea89ab ] |
| |
| In cases the probing fails the log level of the messages should |
| be an error. |
| |
| Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/ethernet/qualcomm/qca_spi.c | 16 ++++++++-------- |
| 1 file changed, 8 insertions(+), 8 deletions(-) |
| |
| --- a/drivers/net/ethernet/qualcomm/qca_spi.c |
| +++ b/drivers/net/ethernet/qualcomm/qca_spi.c |
| @@ -868,22 +868,22 @@ qca_spi_probe(struct spi_device *spi) |
| |
| if ((qcaspi_clkspeed < QCASPI_CLK_SPEED_MIN) || |
| (qcaspi_clkspeed > QCASPI_CLK_SPEED_MAX)) { |
| - dev_info(&spi->dev, "Invalid clkspeed: %d\n", |
| - qcaspi_clkspeed); |
| + dev_err(&spi->dev, "Invalid clkspeed: %d\n", |
| + qcaspi_clkspeed); |
| return -EINVAL; |
| } |
| |
| if ((qcaspi_burst_len < QCASPI_BURST_LEN_MIN) || |
| (qcaspi_burst_len > QCASPI_BURST_LEN_MAX)) { |
| - dev_info(&spi->dev, "Invalid burst len: %d\n", |
| - qcaspi_burst_len); |
| + dev_err(&spi->dev, "Invalid burst len: %d\n", |
| + qcaspi_burst_len); |
| return -EINVAL; |
| } |
| |
| if ((qcaspi_pluggable < QCASPI_PLUGGABLE_MIN) || |
| (qcaspi_pluggable > QCASPI_PLUGGABLE_MAX)) { |
| - dev_info(&spi->dev, "Invalid pluggable: %d\n", |
| - qcaspi_pluggable); |
| + dev_err(&spi->dev, "Invalid pluggable: %d\n", |
| + qcaspi_pluggable); |
| return -EINVAL; |
| } |
| |
| @@ -944,8 +944,8 @@ qca_spi_probe(struct spi_device *spi) |
| } |
| |
| if (register_netdev(qcaspi_devs)) { |
| - dev_info(&spi->dev, "Unable to register net device %s\n", |
| - qcaspi_devs->name); |
| + dev_err(&spi->dev, "Unable to register net device %s\n", |
| + qcaspi_devs->name); |
| free_netdev(qcaspi_devs); |
| return -EFAULT; |
| } |