| From foo@baz Wed Aug 22 09:42:09 CEST 2018 |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| Date: Thu, 12 Jul 2018 15:23:45 +0300 |
| Subject: qlogic: check kstrtoul() for errors |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| [ Upstream commit 5fc853cc01c68f84984ecc2d5fd777ecad78240f ] |
| |
| We accidentally left out the error handling for kstrtoul(). |
| |
| Fixes: a520030e326a ("qlcnic: Implement flash sysfs callback for 83xx adapter") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c |
| +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c |
| @@ -1128,6 +1128,8 @@ static ssize_t qlcnic_83xx_sysfs_flash_w |
| struct qlcnic_adapter *adapter = dev_get_drvdata(dev); |
| |
| ret = kstrtoul(buf, 16, &data); |
| + if (ret) |
| + return ret; |
| |
| switch (data) { |
| case QLC_83XX_FLASH_SECTOR_ERASE_CMD: |
