| From foo@baz Wed Aug 22 09:42:09 CEST 2018 |
| From: "Shuah Khan (Samsung OSG)" <shuah@kernel.org> |
| Date: Tue, 12 Jun 2018 16:46:03 -0600 |
| Subject: selftests: pstore: return Kselftest Skip code for skipped tests |
| |
| From: "Shuah Khan (Samsung OSG)" <shuah@kernel.org> |
| |
| [ Upstream commit 856e7c4b619af622d56b3b454f7bec32a170ac99 ] |
| |
| When pstore_post_reboot test gets skipped because of unmet dependencies |
| and/or unsupported configuration, it returns 0 which is treated as a pass |
| by the Kselftest framework. This leads to false positive result even when |
| the test could not be run. |
| |
| Change it to return kselftest skip code when a test gets skipped to clearly |
| report that the test could not be run. |
| |
| Kselftest framework SKIP code is 4 and the framework prints appropriate |
| messages to indicate that the test is skipped. |
| |
| Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org> |
| Reviewed-by: Kees Cook <keescook@chromium.org> |
| Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| tools/testing/selftests/pstore/pstore_post_reboot_tests | 5 ++++- |
| 1 file changed, 4 insertions(+), 1 deletion(-) |
| |
| --- a/tools/testing/selftests/pstore/pstore_post_reboot_tests |
| +++ b/tools/testing/selftests/pstore/pstore_post_reboot_tests |
| @@ -7,13 +7,16 @@ |
| # |
| # Released under the terms of the GPL v2. |
| |
| +# Kselftest framework requirement - SKIP code is 4. |
| +ksft_skip=4 |
| + |
| . ./common_tests |
| |
| if [ -e $REBOOT_FLAG ]; then |
| rm $REBOOT_FLAG |
| else |
| prlog "pstore_crash_test has not been executed yet. we skip further tests." |
| - exit 0 |
| + exit $ksft_skip |
| fi |
| |
| prlog -n "Mounting pstore filesystem ... " |
