| From foo@baz Wed Aug 22 09:42:09 CEST 2018 |
| From: "Shuah Khan (Samsung OSG)" <shuah@kernel.org> |
| Date: Wed, 13 Jun 2018 21:10:48 -0600 |
| Subject: selftests: user: return Kselftest Skip code for skipped tests |
| |
| From: "Shuah Khan (Samsung OSG)" <shuah@kernel.org> |
| |
| [ Upstream commit d7d5311d4aa9611fe1a5a851e6f75733237a668a ] |
| |
| When user test is skipped because of unmet dependencies and/or |
| unsupported configuration, it exits with error which is treated as |
| a fail by the Kselftest framework. This leads to false negative result |
| even when the test could not be run. |
| |
| Change it to return kselftest skip code when a test gets skipped to |
| clearly report that the test could not be run. Add an explicit check |
| for module presence and return skip code if module isn't present. |
| |
| Kselftest framework SKIP code is 4 and the framework prints appropriate |
| messages to indicate that the test is skipped. |
| |
| Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org> |
| Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| tools/testing/selftests/user/test_user_copy.sh | 7 +++++++ |
| 1 file changed, 7 insertions(+) |
| |
| --- a/tools/testing/selftests/user/test_user_copy.sh |
| +++ b/tools/testing/selftests/user/test_user_copy.sh |
| @@ -1,6 +1,13 @@ |
| #!/bin/sh |
| # Runs copy_to/from_user infrastructure using test_user_copy kernel module |
| |
| +# Kselftest framework requirement - SKIP code is 4. |
| +ksft_skip=4 |
| + |
| +if ! /sbin/modprobe -q -n test_user_copy; then |
| + echo "user: module test_user_copy is not found [SKIP]" |
| + exit $ksft_skip |
| +fi |
| if /sbin/modprobe -q test_user_copy; then |
| /sbin/modprobe -q -r test_user_copy |
| echo "user_copy: ok" |