| From 1e4c8dafbb6bf72fb5eca035b861e39c5896c2b7 Mon Sep 17 00:00:00 2001 |
| From: Eric Biggers <ebiggers@google.com> |
| Date: Fri, 7 Sep 2018 14:33:24 -0700 |
| Subject: ima: fix showing large 'violations' or 'runtime_measurements_count' |
| |
| From: Eric Biggers <ebiggers@google.com> |
| |
| commit 1e4c8dafbb6bf72fb5eca035b861e39c5896c2b7 upstream. |
| |
| The 12 character temporary buffer is not necessarily long enough to hold |
| a 'long' value. Increase it. |
| |
| Signed-off-by: Eric Biggers <ebiggers@google.com> |
| Cc: stable@vger.kernel.org |
| Signed-off-by: Mimi Zohar <zohar@linux.ibm.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| security/integrity/ima/ima_fs.c | 6 +++--- |
| 1 file changed, 3 insertions(+), 3 deletions(-) |
| |
| --- a/security/integrity/ima/ima_fs.c |
| +++ b/security/integrity/ima/ima_fs.c |
| @@ -29,14 +29,14 @@ |
| static DEFINE_MUTEX(ima_write_mutex); |
| |
| static int valid_policy = 1; |
| -#define TMPBUFLEN 12 |
| + |
| static ssize_t ima_show_htable_value(char __user *buf, size_t count, |
| loff_t *ppos, atomic_long_t *val) |
| { |
| - char tmpbuf[TMPBUFLEN]; |
| + char tmpbuf[32]; /* greater than largest 'long' string value */ |
| ssize_t len; |
| |
| - len = scnprintf(tmpbuf, TMPBUFLEN, "%li\n", atomic_long_read(val)); |
| + len = scnprintf(tmpbuf, sizeof(tmpbuf), "%li\n", atomic_long_read(val)); |
| return simple_read_from_buffer(buf, count, ppos, tmpbuf, len); |
| } |
| |