| From a0023bb9dd9bc439d44604eeec62426a990054cd Mon Sep 17 00:00:00 2001 |
| From: Zheyu Ma <zheyuma97@gmail.com> |
| Date: Fri, 22 Oct 2021 09:12:26 +0000 |
| Subject: ata: sata_mv: Fix the error handling of mv_chip_id() |
| |
| From: Zheyu Ma <zheyuma97@gmail.com> |
| |
| commit a0023bb9dd9bc439d44604eeec62426a990054cd upstream. |
| |
| mv_init_host() propagates the value returned by mv_chip_id() which in turn |
| gets propagated by mv_pci_init_one() and hits local_pci_probe(). |
| |
| During the process of driver probing, the probe function should return < 0 |
| for failure, otherwise, the kernel will treat value > 0 as success. |
| |
| Since this is a bug rather than a recoverable runtime error we should |
| use dev_alert() instead of dev_err(). |
| |
| Signed-off-by: Zheyu Ma <zheyuma97@gmail.com> |
| Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/ata/sata_mv.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/drivers/ata/sata_mv.c |
| +++ b/drivers/ata/sata_mv.c |
| @@ -3907,8 +3907,8 @@ static int mv_chip_id(struct ata_host *h |
| break; |
| |
| default: |
| - dev_err(host->dev, "BUG: invalid board index %u\n", board_idx); |
| - return 1; |
| + dev_alert(host->dev, "BUG: invalid board index %u\n", board_idx); |
| + return -EINVAL; |
| } |
| |
| hpriv->hp_flags = hp_flags; |
