| From a7d33f2170b22f003d41d6eb09e11cb70da311c9 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 2 May 2022 12:29:25 -0700 |
| Subject: powerpc/idle: Fix return value of __setup() handler |
| |
| From: Randy Dunlap <rdunlap@infradead.org> |
| |
| [ Upstream commit b793a01000122d2bd133ba451a76cc135b5e162c ] |
| |
| __setup() handlers should return 1 to obsolete_checksetup() in |
| init/main.c to indicate that the boot option has been handled. |
| |
| A return of 0 causes the boot option/value to be listed as an Unknown |
| kernel parameter and added to init's (limited) argument or environment |
| strings. |
| |
| Also, error return codes don't mean anything to obsolete_checksetup() -- |
| only non-zero (usually 1) or zero. So return 1 from powersave_off(). |
| |
| Fixes: 302eca184fb8 ("[POWERPC] cell: use ppc_md->power_save instead of cbe_idle_loop") |
| Reported-by: Igor Zhbanov <izh1979@gmail.com> |
| Signed-off-by: Randy Dunlap <rdunlap@infradead.org> |
| Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> |
| Link: https://lore.kernel.org/r/20220502192925.19954-1-rdunlap@infradead.org |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| arch/powerpc/kernel/idle.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/arch/powerpc/kernel/idle.c b/arch/powerpc/kernel/idle.c |
| index d7216c9abda1..ca79aacfeda2 100644 |
| --- a/arch/powerpc/kernel/idle.c |
| +++ b/arch/powerpc/kernel/idle.c |
| @@ -41,7 +41,7 @@ static int __init powersave_off(char *arg) |
| { |
| ppc_md.power_save = NULL; |
| cpuidle_disable = IDLE_POWERSAVE_OFF; |
| - return 0; |
| + return 1; |
| } |
| __setup("powersave=off", powersave_off); |
| |
| -- |
| 2.35.1 |
| |
