| From 166de41147680414436864af977e739ddc735e56 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 22 Apr 2022 12:53:26 +0200 |
| Subject: rpmsg: qcom_smd: Fix irq_of_parse_and_map() return value |
| |
| From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> |
| |
| [ Upstream commit 1a358d35066487d228a68303d808bc4721c6b1b9 ] |
| |
| The irq_of_parse_and_map() returns 0 on failure, not a negative ERRNO. |
| |
| Fixes: 53e2822e56c7 ("rpmsg: Introduce Qualcomm SMD backend") |
| Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> |
| Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> |
| Link: https://lore.kernel.org/r/20220422105326.78713-1-krzysztof.kozlowski@linaro.org |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/rpmsg/qcom_smd.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c |
| index 312cb7fec5b0..5e67e42e6461 100644 |
| --- a/drivers/rpmsg/qcom_smd.c |
| +++ b/drivers/rpmsg/qcom_smd.c |
| @@ -1258,7 +1258,7 @@ static int qcom_smd_parse_edge(struct device *dev, |
| } |
| |
| irq = irq_of_parse_and_map(node, 0); |
| - if (irq < 0) { |
| + if (!irq) { |
| dev_err(dev, "required smd interrupt missing\n"); |
| return -EINVAL; |
| } |
| -- |
| 2.35.1 |
| |
