| From e98e1cd1b5e59210fc2c4b37dc16319cb8923416 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 18 Apr 2022 10:57:55 +0000 |
| Subject: scsi: megaraid: Fix error check return value of register_chrdev() |
| |
| From: Lv Ruyi <lv.ruyi@zte.com.cn> |
| |
| [ Upstream commit c5acd61dbb32b6bda0f3a354108f2b8dcb788985 ] |
| |
| If major equals 0, register_chrdev() returns an error code when it fails. |
| This function dynamically allocates a major and returns its number on |
| success, so we should use "< 0" to check it instead of "!". |
| |
| Link: https://lore.kernel.org/r/20220418105755.2558828-1-lv.ruyi@zte.com.cn |
| Reported-by: Zeal Robot <zealci@zte.com.cn> |
| Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/scsi/megaraid.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c |
| index 2cbfec6a7466..2f7132edcd3f 100644 |
| --- a/drivers/scsi/megaraid.c |
| +++ b/drivers/scsi/megaraid.c |
| @@ -4705,7 +4705,7 @@ static int __init megaraid_init(void) |
| * major number allocation. |
| */ |
| major = register_chrdev(0, "megadev_legacy", &megadev_fops); |
| - if (!major) { |
| + if (major < 0) { |
| printk(KERN_WARNING |
| "megaraid: failed to register char device\n"); |
| } |
| -- |
| 2.35.1 |
| |
