| From a437f4293a4cb5a05e8cecc4e25b8da0011eec99 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 12 May 2022 15:59:08 +0400 |
| Subject: video: fbdev: clcdfb: Fix refcount leak in clcdfb_of_vram_setup |
| |
| From: Miaoqian Lin <linmq006@gmail.com> |
| |
| [ Upstream commit b23789a59fa6f00e98a319291819f91fbba0deb8 ] |
| |
| of_parse_phandle() returns a node pointer with refcount incremented, we should |
| use of_node_put() on it when not need anymore. Add missing of_node_put() to |
| avoid refcount leak. |
| |
| Fixes: d10715be03bd ("video: ARM CLCD: Add DT support") |
| Signed-off-by: Miaoqian Lin <linmq006@gmail.com> |
| Signed-off-by: Helge Deller <deller@gmx.de> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/video/fbdev/amba-clcd.c | 5 ++++- |
| 1 file changed, 4 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c |
| index 89880b70cc28..ca3707e59633 100644 |
| --- a/drivers/video/fbdev/amba-clcd.c |
| +++ b/drivers/video/fbdev/amba-clcd.c |
| @@ -849,12 +849,15 @@ static int clcdfb_of_vram_setup(struct clcd_fb *fb) |
| return -ENODEV; |
| |
| fb->fb.screen_base = of_iomap(memory, 0); |
| - if (!fb->fb.screen_base) |
| + if (!fb->fb.screen_base) { |
| + of_node_put(memory); |
| return -ENOMEM; |
| + } |
| |
| fb->fb.fix.smem_start = of_translate_address(memory, |
| of_get_address(memory, 0, &size, NULL)); |
| fb->fb.fix.smem_len = size; |
| + of_node_put(memory); |
| |
| return 0; |
| } |
| -- |
| 2.35.1 |
| |
