| From 77238e76b9156d28d86c1e31c00ed2960df0e4de Mon Sep 17 00:00:00 2001 |
| From: "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
| Date: Tue, 31 Oct 2017 00:35:03 -0500 |
| Subject: MIPS: microMIPS: Fix incorrect mask in insn_table_MM |
| |
| From: Gustavo A. R. Silva <garsilva@embeddedor.com> |
| |
| commit 77238e76b9156d28d86c1e31c00ed2960df0e4de upstream. |
| |
| It seems that this is a typo error and the proper bit masking is |
| "RT | RS" instead of "RS | RS". |
| |
| This issue was detected with the help of Coccinelle. |
| |
| Fixes: d6b3314b49e1 ("MIPS: uasm: Add lh uam instruction") |
| Reported-by: Julia Lawall <julia.lawall@lip6.fr> |
| Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> |
| Reviewed-by: James Hogan <jhogan@kernel.org> |
| Patchwork: https://patchwork.linux-mips.org/patch/17551/ |
| Signed-off-by: James Hogan <jhogan@kernel.org> |
| [jhogan@kernel.org: Backported 3.16..4.12] |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| arch/mips/mm/uasm-micromips.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/arch/mips/mm/uasm-micromips.c |
| +++ b/arch/mips/mm/uasm-micromips.c |
| @@ -80,7 +80,7 @@ static struct insn insn_table_MM[] = { |
| { insn_jr, M(mm_pool32a_op, 0, 0, 0, mm_jalr_op, mm_pool32axf_op), RS }, |
| { insn_lb, M(mm_lb32_op, 0, 0, 0, 0, 0), RT | RS | SIMM }, |
| { insn_ld, 0, 0 }, |
| - { insn_lh, M(mm_lh32_op, 0, 0, 0, 0, 0), RS | RS | SIMM }, |
| + { insn_lh, M(mm_lh32_op, 0, 0, 0, 0, 0), RT | RS | SIMM }, |
| { insn_ll, M(mm_pool32c_op, 0, 0, (mm_ll_func << 1), 0, 0), RS | RT | SIMM }, |
| { insn_lld, 0, 0 }, |
| { insn_lui, M(mm_pool32i_op, mm_lui_op, 0, 0, 0, 0), RS | SIMM }, |
