| From 9341c0012c134aba69508eb0e59e1086e2249d93 Mon Sep 17 00:00:00 2001 |
| From: Wen Yang <wen.yang99@zte.com.cn> |
| Date: Tue, 5 Mar 2019 19:34:05 +0800 |
| Subject: arm64: cpu_ops: fix a leaked reference by adding missing of_node_put |
| |
| [ Upstream commit 92606ec9285fb84cd9b5943df23f07d741384bfc ] |
| |
| The call to of_get_next_child returns a node pointer with refcount |
| incremented thus it must be explicitly decremented after the last |
| usage. |
| |
| Detected by coccinelle with the following warnings: |
| ./arch/arm64/kernel/cpu_ops.c:102:1-7: ERROR: missing of_node_put; |
| acquired a node pointer with refcount incremented on line 69, but |
| without a corresponding object release within this function. |
| |
| Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> |
| Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> |
| Cc: Catalin Marinas <catalin.marinas@arm.com> |
| Cc: Will Deacon <will.deacon@arm.com> |
| Cc: linux-arm-kernel@lists.infradead.org |
| Cc: linux-kernel@vger.kernel.org |
| Signed-off-by: Will Deacon <will.deacon@arm.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| arch/arm64/kernel/cpu_ops.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/arch/arm64/kernel/cpu_ops.c b/arch/arm64/kernel/cpu_ops.c |
| index ea001241bdd47..00f8b8612b69f 100644 |
| --- a/arch/arm64/kernel/cpu_ops.c |
| +++ b/arch/arm64/kernel/cpu_ops.c |
| @@ -85,6 +85,7 @@ static const char *__init cpu_read_enable_method(int cpu) |
| pr_err("%pOF: missing enable-method property\n", |
| dn); |
| } |
| + of_node_put(dn); |
| } else { |
| enable_method = acpi_get_enable_method(cpu); |
| if (!enable_method) { |
| -- |
| 2.20.1 |
| |
