| From 8944eed2656268cde9909e9b2fddc294954a4ae5 Mon Sep 17 00:00:00 2001 |
| From: Wen Yang <wen.yang99@zte.com.cn> |
| Date: Tue, 26 Feb 2019 16:17:50 +0800 |
| Subject: ASoC: fsl_utils: fix a leaked reference by adding missing of_node_put |
| |
| [ Upstream commit c705247136a523488eac806bd357c3e5d79a7acd ] |
| |
| The call to of_parse_phandle returns a node pointer with refcount |
| incremented thus it must be explicitly decremented after the last |
| usage. |
| |
| Detected by coccinelle with the following warnings: |
| ./sound/soc/fsl/fsl_utils.c:74:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 38, but without a corresponding object release within this function. |
| |
| Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> |
| Cc: Timur Tabi <timur@kernel.org> |
| Cc: Nicolin Chen <nicoleotsuka@gmail.com> |
| Cc: Xiubo Li <Xiubo.Lee@gmail.com> |
| Cc: Fabio Estevam <festevam@gmail.com> |
| Cc: Liam Girdwood <lgirdwood@gmail.com> |
| Cc: Mark Brown <broonie@kernel.org> |
| Cc: Jaroslav Kysela <perex@perex.cz> |
| Cc: Takashi Iwai <tiwai@suse.com> |
| Cc: alsa-devel@alsa-project.org |
| Cc: linuxppc-dev@lists.ozlabs.org |
| Cc: linux-kernel@vger.kernel.org |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| sound/soc/fsl/fsl_utils.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/sound/soc/fsl/fsl_utils.c b/sound/soc/fsl/fsl_utils.c |
| index 9981668ab5909..040d06b89f00a 100644 |
| --- a/sound/soc/fsl/fsl_utils.c |
| +++ b/sound/soc/fsl/fsl_utils.c |
| @@ -71,6 +71,7 @@ int fsl_asoc_get_dma_channel(struct device_node *ssi_np, |
| iprop = of_get_property(dma_np, "cell-index", NULL); |
| if (!iprop) { |
| of_node_put(dma_np); |
| + of_node_put(dma_channel_np); |
| return -EINVAL; |
| } |
| *dma_id = be32_to_cpup(iprop); |
| -- |
| 2.20.1 |
| |