| From a74e77dfd295b3069cf36992a36e671497078cac Mon Sep 17 00:00:00 2001 |
| From: Wen Yang <wen.yang99@zte.com.cn> |
| Date: Tue, 26 Feb 2019 16:17:49 +0800 |
| Subject: ASoC: wcd9335: fix a leaked reference by adding missing of_node_put |
| |
| [ Upstream commit 64b92de9603f22b5455da925ee57268ef7fb4e80 ] |
| |
| The call to of_parse_phandle returns a node pointer with refcount |
| incremented thus it must be explicitly decremented after the last |
| usage. |
| |
| Detected by coccinelle with the following warnings: |
| ./sound/soc/codecs/wcd9335.c:5193:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 5183, but without a correspon ding object release within this function. |
| |
| Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> |
| Cc: Liam Girdwood <lgirdwood@gmail.com> |
| Cc: Mark Brown <broonie@kernel.org> |
| Cc: Jaroslav Kysela <perex@perex.cz> |
| Cc: Takashi Iwai <tiwai@suse.com> |
| Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> |
| Cc: Vinod Koul <vkoul@kernel.org> |
| Cc: Dan Carpenter <dan.carpenter@oracle.com> (commit_signer:1/11=9%,authored:1/11=9%) |
| Cc: alsa-devel@alsa-project.org |
| Cc: linux-kernel@vger.kernel.org |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| sound/soc/codecs/wcd9335.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c |
| index 981f88a5f6154..a04a7cedd99de 100644 |
| --- a/sound/soc/codecs/wcd9335.c |
| +++ b/sound/soc/codecs/wcd9335.c |
| @@ -5188,6 +5188,7 @@ static int wcd9335_slim_status(struct slim_device *sdev, |
| |
| wcd->slim = sdev; |
| wcd->slim_ifc_dev = of_slim_get_device(sdev->ctrl, ifc_dev_np); |
| + of_node_put(ifc_dev_np); |
| if (!wcd->slim_ifc_dev) { |
| dev_err(dev, "Unable to get SLIM Interface device\n"); |
| return -EINVAL; |
| -- |
| 2.20.1 |
| |
