| From 013ddf0ccebd14b58bf5dbba29f6e39cf9ccc042 Mon Sep 17 00:00:00 2001 |
| From: Wen Yang <wen.yang99@zte.com.cn> |
| Date: Mon, 1 Apr 2019 09:37:48 +0800 |
| Subject: cpufreq: ap806: fix possible object reference leak |
| |
| [ Upstream commit b623fa320f8360f049a6f3c3ccc487cb85af4c5b ] |
| |
| The call to of_find_compatible_node returns a node pointer with refcount |
| incremented thus it must be explicitly decremented after the last |
| usage. |
| |
| Detected by coccinelle with the following warnings: |
| ./drivers/cpufreq/armada-8k-cpufreq.c:187:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 130, but without a corresponding object release within this function. |
| ./drivers/cpufreq/armada-8k-cpufreq.c:191:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 130, but without a corresponding object release within this function. |
| |
| Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> |
| Cc: Jason Cooper <jason@lakedaemon.net> |
| Cc: Andrew Lunn <andrew@lunn.ch> |
| Cc: Gregory Clement <gregory.clement@bootlin.com> |
| Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> |
| Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> |
| Cc: Viresh Kumar <viresh.kumar@linaro.org> |
| Cc: linux-arm-kernel@lists.infradead.org |
| Cc: linux-pm@vger.kernel.org |
| Cc: linux-kernel@vger.kernel.org |
| Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/cpufreq/armada-8k-cpufreq.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/cpufreq/armada-8k-cpufreq.c b/drivers/cpufreq/armada-8k-cpufreq.c |
| index b3f4bd647e9b3..988ebc326bdbb 100644 |
| --- a/drivers/cpufreq/armada-8k-cpufreq.c |
| +++ b/drivers/cpufreq/armada-8k-cpufreq.c |
| @@ -132,6 +132,7 @@ static int __init armada_8k_cpufreq_init(void) |
| of_node_put(node); |
| return -ENODEV; |
| } |
| + of_node_put(node); |
| |
| nb_cpus = num_possible_cpus(); |
| freq_tables = kcalloc(nb_cpus, sizeof(*freq_tables), GFP_KERNEL); |
| -- |
| 2.20.1 |
| |