| From 43a9582fbef8434a49aa4bcb529992b112a999fb Mon Sep 17 00:00:00 2001 |
| From: Wen Yang <wen.yang99@zte.com.cn> |
| Date: Mon, 1 Apr 2019 09:37:49 +0800 |
| Subject: cpufreq: imx6q: fix possible object reference leak |
| |
| [ Upstream commit ddb64c5db3cc8fb9c1242214d5798b2c2865681c ] |
| |
| The call to of_node_get returns a node pointer with refcount |
| incremented thus it must be explicitly decremented after the last |
| usage. |
| |
| Detected by coccinelle with the following warnings: |
| ./drivers/cpufreq/imx6q-cpufreq.c:391:4-10: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 348, but without a corresponding object release within this function. |
| ./drivers/cpufreq/imx6q-cpufreq.c:395:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 348, but without a corresponding object release within this function. |
| |
| Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> |
| Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> |
| Cc: Viresh Kumar <viresh.kumar@linaro.org> |
| Cc: Shawn Guo <shawnguo@kernel.org> |
| Cc: Sascha Hauer <s.hauer@pengutronix.de> |
| Cc: Pengutronix Kernel Team <kernel@pengutronix.de> |
| Cc: Fabio Estevam <festevam@gmail.com> |
| Cc: NXP Linux Team <linux-imx@nxp.com> |
| Cc: linux-pm@vger.kernel.org |
| Cc: linux-arm-kernel@lists.infradead.org |
| Cc: linux-kernel@vger.kernel.org |
| Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/cpufreq/imx6q-cpufreq.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c |
| index a4ff09f91c8f8..3e17560b1efe3 100644 |
| --- a/drivers/cpufreq/imx6q-cpufreq.c |
| +++ b/drivers/cpufreq/imx6q-cpufreq.c |
| @@ -388,11 +388,11 @@ static int imx6q_cpufreq_probe(struct platform_device *pdev) |
| ret = imx6ul_opp_check_speed_grading(cpu_dev); |
| if (ret) { |
| if (ret == -EPROBE_DEFER) |
| - return ret; |
| + goto put_node; |
| |
| dev_err(cpu_dev, "failed to read ocotp: %d\n", |
| ret); |
| - return ret; |
| + goto put_node; |
| } |
| } else { |
| imx6q_opp_check_speed_grading(cpu_dev); |
| -- |
| 2.20.1 |
| |
