| From 534170f427cf4c4500ec61cf5283e01e866cc774 Mon Sep 17 00:00:00 2001 |
| From: Wen Yang <wen.yang99@zte.com.cn> |
| Date: Mon, 1 Apr 2019 09:37:52 +0800 |
| Subject: cpufreq/pasemi: fix possible object reference leak |
| |
| [ Upstream commit a9acc26b75f652f697e02a9febe2ab0da648a571 ] |
| |
| The call to of_get_cpu_node returns a node pointer with refcount |
| incremented thus it must be explicitly decremented after the last |
| usage. |
| |
| Detected by coccinelle with the following warnings: |
| ./drivers/cpufreq/pasemi-cpufreq.c:212:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 147, but without a corresponding object release within this function. |
| ./drivers/cpufreq/pasemi-cpufreq.c:220:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 147, but without a corresponding object release within this function. |
| |
| Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> |
| Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> |
| Cc: Viresh Kumar <viresh.kumar@linaro.org> |
| Cc: linuxppc-dev@lists.ozlabs.org |
| Cc: linux-pm@vger.kernel.org |
| Cc: linux-kernel@vger.kernel.org |
| Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/cpufreq/pasemi-cpufreq.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/cpufreq/pasemi-cpufreq.c b/drivers/cpufreq/pasemi-cpufreq.c |
| index 75dfbd2a58ea6..c7710c149de85 100644 |
| --- a/drivers/cpufreq/pasemi-cpufreq.c |
| +++ b/drivers/cpufreq/pasemi-cpufreq.c |
| @@ -146,6 +146,7 @@ static int pas_cpufreq_cpu_init(struct cpufreq_policy *policy) |
| |
| cpu = of_get_cpu_node(policy->cpu, NULL); |
| |
| + of_node_put(cpu); |
| if (!cpu) |
| goto out; |
| |
| -- |
| 2.20.1 |
| |
