| From 382294a033f7c8282d63cd23bdf92fd2c5809808 Mon Sep 17 00:00:00 2001 |
| From: Arnd Bergmann <arnd@arndb.de> |
| Date: Mon, 4 Mar 2019 15:29:10 -0500 |
| Subject: media: staging/intel-ipu3: mark PM function as __maybe_unused |
| |
| [ Upstream commit 948dff7cfa1d7653e7828e7b905863bd24ca5c02 ] |
| |
| The imgu_rpm_dummy_cb() looks like an API misuse that is explained |
| in the comment above it. Aside from that, it also causes a warning |
| when power management support is disabled: |
| |
| drivers/staging/media/ipu3/ipu3.c:794:12: error: 'imgu_rpm_dummy_cb' defined but not used [-Werror=unused-function] |
| |
| The warning is at least easy to fix by marking the function as |
| __maybe_unused. |
| |
| Fixes: 7fc7af649ca7 ("media: staging/intel-ipu3: Add imgu top level pci device driver") |
| |
| Signed-off-by: Arnd Bergmann <arnd@arndb.de> |
| Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> |
| Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/staging/media/ipu3/ipu3.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/staging/media/ipu3/ipu3.c b/drivers/staging/media/ipu3/ipu3.c |
| index d575ac78c8f0b..d00d26264c37d 100644 |
| --- a/drivers/staging/media/ipu3/ipu3.c |
| +++ b/drivers/staging/media/ipu3/ipu3.c |
| @@ -791,7 +791,7 @@ static int __maybe_unused imgu_resume(struct device *dev) |
| * PCI rpm framework checks the existence of driver rpm callbacks. |
| * Place a dummy callback here to avoid rpm going into error state. |
| */ |
| -static int imgu_rpm_dummy_cb(struct device *dev) |
| +static __maybe_unused int imgu_rpm_dummy_cb(struct device *dev) |
| { |
| return 0; |
| } |
| -- |
| 2.20.1 |
| |
